Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Content page example #121

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

frankieroberto
Copy link
Contributor

This example page has a selection of content components on it. However it’s not linked to from anywhere and is an orphaned page.

I’m not sure it has much value, as all of the components are available separately on the Design System website (where there’s also guidance on when to use them).

Think this can be deleted.

Screenshot for posterity:

page-example

This example page has a selection of content components on it. However it’s not linked to from anywhere.
@frankieroberto frankieroberto temporarily deployed to nhs-prototyp-remove-con-ot2xqx November 17, 2024 23:03 Inactive
@anandamaryon1
Copy link
Contributor

Just looked into this and it's linked to from the prototype index page:
image

But I agree that it can be removed and instead users can grab code from the service manual. Will need to also update the index of prototype kit to remove the link though.

@frankieroberto
Copy link
Contributor Author

@anandamaryon1 ah, so we accidentally orphaned it when splitting the docs site from the kit, as that index page doesn’t exist within the new website... 👍 😂

I'll remove it from the docs site and then open a separate PR to remove it from the kit itself (and the link to it).

@frankieroberto frankieroberto merged commit c47cc06 into main Nov 18, 2024
4 checks passed
@frankieroberto frankieroberto deleted the remove-content-page-example branch November 18, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants