Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.1 #77

Merged
merged 30 commits into from
Feb 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
67f966f
Added inline comments for adding custom CSS/Sass
davidhunter08 Feb 15, 2019
4519a93
Merge pull request #66 from nhsuk/custom-css-comment
davidhunter08 Feb 15, 2019
ed39e75
Updated index.html page comments
davidhunter08 Feb 15, 2019
0de5ea7
Merge pull request #67 from nhsuk/index-page-comments
davidhunter08 Feb 15, 2019
9b2f0ed
Iterated installation docs
davidhunter08 Feb 8, 2019
e6ff797
Install docs
davidhunter08 Feb 9, 2019
368bf39
Fixed grammar mistake on terminal oage
davidhunter08 Feb 9, 2019
320498f
Installation docs for Mac
davidhunter08 Feb 11, 2019
9ab3bb8
Updated page titles
davidhunter08 Feb 11, 2019
b20b500
Updated docs images
davidhunter08 Feb 11, 2019
e265464
Iterated install docs
davidhunter08 Feb 11, 2019
ac56da0
Updated wording - install and check it works
davidhunter08 Feb 11, 2019
6f2bdc4
Fix the word ordering of page titles
chrimesdev Feb 18, 2019
303e859
Bump package to version 1.0.0 with CHANGELOG entry for release
chrimesdev Feb 18, 2019
3c13d80
Remove unused concurrently dependency
chrimesdev Feb 18, 2019
f97f8ec
Updated install docs for windows
davidhunter08 Feb 18, 2019
6e542f4
Updated content on install guide
davidhunter08 Feb 18, 2019
cc3fdec
Merge pull request #68 from nhsuk/docs/install-version-2
davidhunter08 Feb 18, 2019
89920d1
Merge branch 'develop' into feature/versioning
chrimesdev Feb 19, 2019
85073e7
Merge pull request #69 from nhsuk/feature/versioning
davidhunter08 Feb 19, 2019
a32ae9d
Updated labels on install page
davidhunter08 Feb 19, 2019
52fc118
Merge pull request #73 from nhsuk/install-guide
davidhunter08 Feb 19, 2019
56f8cfa
Update packages
mcheung-nhs Feb 20, 2019
07ff6b7
Display the prototype kit version number
chrimesdev Feb 21, 2019
2e6bdcd
Merge branch 'master' into feature/versioning-fixes
chrimesdev Feb 21, 2019
60d6ef2
[refs #71] Use consistent header and footer for branching example pages
chrimesdev Feb 21, 2019
1114c6c
Merge pull request #75 from nhsuk/feature/versioning-fixes
davidhunter08 Feb 21, 2019
92335ad
Merge pull request #76 from nhsuk/fix/header-footer-consistency
davidhunter08 Feb 21, 2019
4c8e9ec
Merge pull request #74 from nhsuk/update/packages
chrimesdev Feb 21, 2019
029b35d
Release notes for 1.0.1 and bump package version
chrimesdev Feb 21, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# NHS.UK prototype kit Changelog

## 1.0.1 - Feb 21, 2019

:new: **New features**

- [Installation guides update for Windows and Mac following testing with users](https://github.com/nhsuk/nhsuk-prototype-kit/pull/68)
- The prototype kit now is properly versioned and is the version is indicated in `package.json` `version` field and also on the index page of the docs.

:wrench: **Fixes**

- [Header and footer inconsistency on the branching examples](https://github.com/nhsuk/nhsuk-prototype-kit/issues/71)
- Fix inconsistencies with page titles, should be `Page name - NHS.UK prototype kit`

## 1.0.0 - Feb 5, 2019

:tada: **Official release of the NHS.UK prototype kit**

- v1.0.0 of the NHS.UK prototype kit!
5 changes: 4 additions & 1 deletion app.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const sessionInMemory = require('express-session')
dotenv.config()

// Local dependencies
const packageInfo = require('./package.json');
const authentication = require('./middleware/authentication');
const automaticRouting = require('./middleware/auto-routing');
const config = require('./app/config');
Expand Down Expand Up @@ -56,7 +57,8 @@ var nunjucksConfig = {

nunjucksConfig.express = app

var nunjucksAppEnv = nunjucks.configure(appViews, nunjucksConfig)
var nunjucksAppEnv = nunjucks.configure(appViews, nunjucksConfig);
nunjucksAppEnv.addGlobal('version', packageInfo.version);

// Add Nunjucks filters
utils.addNunjucksFilters(nunjucksAppEnv)
Expand Down Expand Up @@ -186,6 +188,7 @@ if (useDocumentation || onlyDocumentation == 'true') {
autoescape: true,
express: documentationApp
});
nunjucksAppEnv.addGlobal('version', packageInfo.version);

// Add Nunjucks filters
utils.addNunjucksFilters(nunjucksAppEnv)
Expand Down
4 changes: 3 additions & 1 deletion app/assets/sass/main.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@
@import 'components/panel-confirmation';
@import 'components/related-nav';

// Add your extra styles here...
///////////////////////////////////////////
// Add your custom CSS/Sass styles below...
///////////////////////////////////////////
2 changes: 1 addition & 1 deletion app/views/examples/branching/answer-no.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% extends "layouts/layout.html" %}
{% extends "layouts/layout-transactional.html" %}

{% set mainClasses = 'nhsuk-main-wrapper--s' %}

Expand Down
2 changes: 1 addition & 1 deletion app/views/examples/branching/answer-yes.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% extends "layouts/layout.html" %}
{% extends "layouts/layout-transactional.html" %}

{% set mainClasses = 'nhsuk-main-wrapper--s' %}

Expand Down
16 changes: 11 additions & 5 deletions app/views/index.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
<!--
ADDING CUSTOM CSS
Add your custom CSS/Sass to /app/assets/sass/main.scss
-->


<!-- Extends the layout from /app/views/layouts/layout.html -->
{% extends 'layouts/layout.html' %}

<!-- Set the page title inside this block -->
{% block pageTitle %}
Prototype kit
NHS.UK prototype kit
{% endblock %}

<!-- Breadcrumb goes inside this block -->
Expand All @@ -14,13 +20,13 @@
<div class="nhsuk-grid-row">
<div class="nhsuk-grid-column-two-thirds">

<!-- Page title goes here -->
<!-- Change the page title here -->
<h1>
NHS.UK prototype kit
<span class="nhsuk-caption-xl nhsuk-caption--bottom">Version {{version}}</span>
</h1>
<!-- End of page title -->

<!-- Content goes here -->
<!-- Add your content here -->

<p class="nhsuk-body-l">This kit lets you rapidly create HTML prototypes of NHS services.</p>

Expand All @@ -33,7 +39,7 @@ <h2 class="nhsuk-heading-m">About this page</h2>
<h2 class="nhsuk-heading-m">Examples and documentation</h2>

<ul>
<li><a href="/docs">Example pages and documentation</a></li>
<li><a href="/docs/how-tos">Example pages and documentation</a></li>
<li><a href="https://beta.nhs.uk/service-manual/styles-components-patterns">NHS digital service manual</a>
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/layout-nhsuk.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<!-- Set the page title inside this block -->
{% block pageTitle %}
NHS.UK prototype kit - NHS.UK page layout
NHS.UK page layout - NHS.UK prototype kit
{% endblock %}

<!-- Header goes inside this block -->
Expand Down
2 changes: 1 addition & 1 deletion app/views/templates/blank-nhsuk.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout-nhsuk.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Blank template
Blank template - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand Down
2 changes: 1 addition & 1 deletion app/views/templates/blank-transactional.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout-transactional.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Blank transactional template
Blank transactional template - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand Down
2 changes: 1 addition & 1 deletion app/views/templates/check-your-answers.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout-transactional.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Check your answers template
Check your answers template - NHS.UK prototype kit
{% endblock %}

{% block content %}
Expand Down
2 changes: 1 addition & 1 deletion app/views/templates/confirmation-page.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout-transactional.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Confirmation page template
Confirmation page template - NHS.UK prototype kit
{% endblock %}

{% block content %}
Expand Down
2 changes: 1 addition & 1 deletion app/views/templates/content-page.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout-nhsuk.html' %}

{% block pageTitle %}
NHS.UK prototype Kit - Content page template
Content page template - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand Down
2 changes: 1 addition & 1 deletion app/views/templates/start-page.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout-nhsuk.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Start page template
Start page template - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand Down
Binary file added docs/assets/images/mac/download-folder.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/mac/download-move.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/mac/download-rename.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/mac/download-unzip.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/mac/terminal-folder.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/images/mac/terminal-node-version.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/images/mac/terminal-node.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/mac/terminal-npm-run-3000.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/images/mac/terminal-npm-run.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/assets/images/mac/terminal.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/cd.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/command-prompt.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/download-folder.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/download-move.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/download-rename.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/download-unzip.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/node-check.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/node-version.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/node.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/npm-install.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/npm-run.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/assets/images/windows/zip-download.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 15 additions & 2 deletions docs/documentation_routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,27 @@ router.get('/', function(req , res){
res.render('index');
});

// Install routing
router.post('/install', function (req, res) {
let install = req.body.install;

if (install === 'Simple') {
res.redirect('/docs/install/simple')
} if (install === 'Developer') {
res.redirect('/docs/install/advanced')
} else {
res.redirect('/docs/install/download-zip')
}
});

// Mac or Windows install
router.post('/install/mac', function (req, res) {
let machine = req.body.machine;

if (machine === 'Mac') {
res.redirect('/docs/install/mac/requirements')
res.redirect('/docs/install/mac/terminal')
} else {
res.redirect('/docs/install/windows/requirements')
res.redirect('/docs/install/windows/terminal')
}
});

Expand Down
2 changes: 1 addition & 1 deletion docs/views/about.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout.html' %}

{% block pageTitle %}
NHS.UK prototype kit - About
About - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand Down
4 changes: 2 additions & 2 deletions docs/views/install/advanced.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Advanced install
Developer friendly install guide - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand All @@ -22,7 +22,7 @@

<div class="nhsuk-grid-column-two-thirds">

<h1>Advanced install guide</h1>
<h1>Developer friendly install guide</h1>

<p class="nhsuk-body-l">The prototype kit is built on the <a href="http://expressjs.com/" target="_blank">Express<span class="nhsuk-u-visually-hidden">opens in new window</span></a></a> framework, and uses the <a href="https://github.com/nhsuk/nhsuk-frontend" target="_blank">NHS.UK frontend<span class="nhsuk-u-visually-hidden">opens in new window</span></a>.</p>

Expand Down
37 changes: 22 additions & 15 deletions docs/views/install/check-it-works.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends 'layouts/layout.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Check it works
Check it works - NHS.UK prototype kit
{% endblock %}

{% block beforeContent %}
Expand All @@ -23,38 +23,45 @@
<div class="nhsuk-grid-column-two-thirds">

<h1>
<span class="nhsuk-caption-l">Step 10 of 10</span>
<span class="nhsuk-caption-l">Step 8 of 8</span>
Check it works
</h1>

<h2 class="nhsuk-u-visually-hidden">Check your local host</h2>

<p class="nhsuk-body-l">In your web browser, visit <a href="http://localhost:3000" target="_blank">http://localhost:3000 <span class="nhsuk-u-visually-hidden">opens in a new tab</span></a></p>

<p>You should see the prototype welcome page.</p>

<img class="app-img-guide nhsuk-u-margin-bottom-0" alt="Screenshot of the prototype kit welcome page" src="/images/prototype-kit-landing-page.png" />

<h2>Quitting the kit</h2>
<details class="nhsuk-details nhsuk-expander nhsuk-u-margin-bottom-7">
<summary class="nhsuk-details__summary">
<span class="nhsuk-details__summary-text">
I don't see that page
</span>
</summary>
<div class="nhsuk-details__text">
<h3>If you don't see that page</h3>

<p>Sometimes you need to stop the kit running to use things like Git or Heroku. You can learn about Git and Heroku in the <a href="/docs/how-tos/">How to guides</a>.</p>

<p>It’s okay to leave the kit running for days or while your computer is asleep.</p>
{% block branchingContent %}
{% endblock %}

<h3>To quit the kit</h3>
<img class="app-img-guide nhsuk-u-margin-bottom-0" alt="Screenshot of the terminal running the kit" src="/images/mac/terminal-npm-run-3000.png" />

{% block branchingContent %}
{% endblock %}
<p>Make sure the number in the terminal matches the one in the web address.</p>

<p>The kit automatically changes to <strong>http://localhost:3001</strong> if <strong>http://localhost:3000</strong> is already in use.</p>
</div>
</details>

<h2>Installation complete</h2>

<p>The kit is now installed. Congratulations!</p>

<div class="nhsuk-panel">

<h2>Get started</h2>

<p><a href="/docs/how-tos/making-pages">Start making pages</a></p>
<h2>Getting going</h2>

</div>
<p><a href="/docs/how-tos/making-pages">Start making pages</a></p>

{% block pagination %}
{% endblock %}
Expand Down
47 changes: 47 additions & 0 deletions docs/views/install/download-zip.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{% extends 'layouts/layout.html' %}

{% block pageTitle %}
NHS.UK prototype kit - Download the kit
{% endblock %}

{% block beforeContent %}
{{ breadcrumb({
items: [
{
href: "/docs",
text: "Home"
}
],
href: "/docs/install",
text: "Install"
}) }}
{% endblock %}

{% block content %}
<div class="nhsuk-grid-row">

<div class="nhsuk-grid-column-two-thirds">

<h1>
Download the kit
</h1>

<h2>Zip file</h2>

<p>The simplest way to get the kit is to <a href="https://github.com/nhsuk/nhsuk-prototype-kit/archive/master.zip" data-link="download">download it as a zip</a>.</p>

<h2>GitHub</h2>

<p>You can also clone or download a copy from <a href="https://github.com/nhsuk/nhsuk-prototype-kit">GitHub</a></p>

{{ backLink({
"href": "/docs/install",
"text": "Back to Installing the kit",
"classes": "nhsuk-u-margin-top-6"
}) }}


</div>

</div>
{% endblock %}
Loading