Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record PDS error responses in Sentry #2757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Record PDS error responses in Sentry #2757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/lib/nhs/pds.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ def get_patient(nhs_number)
"personal-demographics/FHIR/R4/Patient/#{nhs_number}"
)
rescue Faraday::BadRequestError => e
add_sentry_breadcrumb(e)

if is_error?(e, "INVALID_RESOURCE_ID")
raise InvalidNHSNumber, nhs_number
else
Expand All @@ -56,10 +58,23 @@ def search_patients(attributes)
"personal-demographics/FHIR/R4/Patient",
attributes
)
rescue Faraday::BadRequestError => e
add_sentry_breadcrumb(e)
raise
end

private

def add_sentry_breadcrumb(error)
crumb =
Sentry::Breadcrumb.new(
category: "http.response",
data: error.response,
level: "error"
)
Sentry.add_breadcrumb(crumb)
end

def is_error?(error, code)
response = JSON.parse(error.response_body)

Expand Down
Loading