Don't create parents by default in tests #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
changed the title
thomasleese
force-pushed
the
refactor-parent-factory
branch
from
b916797 to
2581d3b
Compare
This simplifies the patient factory to not create parents by default to improve test performance and match production where patients won't necessarily always have parents attached to them.
thomasleese
force-pushed
the
refactor-parent-factory
branch
from
2581d3b to
8b1d534
Compare
thomasleese
changed the title
|
tvararu
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the patient factory to not create parents by default to improve test performance and match production where patients won't necessarily always have parents attached to them.