Add patients back to sessions if valid #2723
Open
+57
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaka
approved these changes
Dec 12, 2024
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
88006fa to
7fc9a9a
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
7fc9a9a to
1ca5931
Compare
tvararu
requested changes
Dec 13, 2024
tvararu
approved these changes
Dec 13, 2024
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
1ca5931 to
0be39ac
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
0be39ac to
6aa9445
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
6aa9445 to
3367f55
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
3367f55 to
b1341b6
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
b1341b6 to
9b4fe3c
Compare
tvararu
added
🐞 bug
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
9b4fe3c to
108cd3d
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
108cd3d to
e1c141a
Compare
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
e1c141a to
070b6e8
Compare
If we look up a patient in PDS and they're now marked as valid (and previously were invalid), we should add them to any upcoming sessions if approriate. This uses a `SchoolMove` instance to handle this to apply the same logic used elsewhere in the service.
thomasleese
force-pushed
the
invalidate-add-to-sessions
branch
from
070b6e8 to
3de8253
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we look up a patient in PDS and they're now marked as valid (and previously were invalid), we should add them to any upcoming sessions if approriate. This uses a
SchoolMoveinstance to handle this to apply the same logic used elsewhere in the service.