[PRMP-NONE] Fixed misleading error log & added intermittent test warn…

…ing log
nhsconnect · Jul 16, 2024 · 28494ad · 28494ad
1 parent e846a13
commit 28494ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...ntegration/java/uk/nhs/prm/deductions/nemseventprocessor/metrics/MetricPublisherTest.java b/...ntegration/java/uk/nhs/prm/deductions/nemseventprocessor/metrics/MetricPublisherTest.java
@@ -41,6 +41,9 @@ class MetricPublisherTest {
 
     @Test
     void shouldPutHealthMetricDataIntoCloudWatch() {
+        // TODO investigate why this test intermittently fails
+        System.out.println("If this test fails on the pipeline, rerun it. It fails intermittently.");
+
         publisher.publishMetric("Health", HEALTHY_HEALTH_VALUE);
 
         List<Metric> metrics = fetchMetricsMatching("NemsEventProcessor", "Health");

diff --git a/...gration/java/uk/nhs/prm/deductions/nemseventprocessor/nemsevents/LocalStackAwsConfig.java b/...gration/java/uk/nhs/prm/deductions/nemseventprocessor/nemsevents/LocalStackAwsConfig.java
@@ -21,7 +21,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
-
+@Slf4j
 @TestConfiguration
 public class LocalStackAwsConfig {
 
@@ -42,7 +42,7 @@ public class LocalStackAwsConfig {
     @Bean
     @Primary
     public static SqsClient sqsClient(@Value("${localstack.url}") String localstackUrl) {
-        System.err.println("!!!! localstack config sqsClient creation");
+        log.info("localstack config sqsClient creation");
         return SqsClient.builder()
                 .credentialsProvider(StaticCredentialsProvider.create(AwsBasicCredentials.create("FAKE", "FAKE")))
                 .region(Region.EU_WEST_2)