Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRMT-4727 #254

Closed
wants to merge 3 commits into from
Closed

PRMT-4727 #254

wants to merge 3 commits into from

Conversation

martin-nhs
Copy link
Contributor

  • Added logic to store FailureReason upon receiving a Negative Acknowledgement.

Signed-off-by: martin-nhs <martin.taylor22@nhs.net>
Signed-off-by: martin-nhs <martin.taylor22@nhs.net>
Signed-off-by: martin-nhs <martin.taylor22@nhs.net>
inboundConversationId, INBOUND_FAILED.name(), failureCode);
public void updateConversationTransferStatusWithFailure(UUID inboundConversationId, String failureCode, FailureReason failureReason) {
transferRepository.updateConversationStatusWithFailure(inboundConversationId, failureCode, failureReason);
log.info("Updated conversation record with Inbound Conversation ID {} to {} - with failure code {} and reason {}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could we have quotes around the reason text.

Copy link
Contributor

@chrisbloe-nhse chrisbloe-nhse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding out if the Ack contains some free text that we could populate the table with.

@martin-nhs
Copy link
Contributor Author

Not required.

@martin-nhs martin-nhs closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants