PRMT-3413 E2E testing - Unexpected Interaction ID and NHS number #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joefong-nhs
commented
Aug 14, 2023
joefong-nhs
commented
- Move the tests from previous branch (PRMT-3413) to this branch
- Modify the tests to adapt to the configurations after major refactoring
- Add HealthCheckService and EhrOutServiceProperties in order to call the health check endpoints of each services
- Remove some unused imports
…e test to adapt to current configurations
martin-nhs
reviewed
Aug 15, 2023
src/main/java/uk/nhs/prm/e2etests/property/EhrOutServiceProperties.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 15, 2023
src/main/java/uk/nhs/prm/e2etests/service/HealthCheckService.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 15, 2023
src/main/java/uk/nhs/prm/e2etests/service/HealthCheckService.java
Outdated
Show resolved
Hide resolved
martin-nhs
reviewed
Aug 15, 2023
martin-nhs
approved these changes
Aug 15, 2023
|
|
||
|
|
||
| public boolean verifyNoMessageContaining(String substring, int secondsToPoll) { | ||
| // Queue the queue repeatedly for {secondsToPoll}, and return true only if a message with given substring NEVER appeared throughout the period. |
There was a problem hiding this comment.
Suggested change
| // Queue the queue repeatedly for {secondsToPoll}, and return true only if a message with given substring NEVER appeared throughout the period. | |
| // Poll the queue repeatedly for {secondsToPoll}, and return true only if a message with given substring NEVER appeared throughout the period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.