Addressed pull request comments/removed @JsonProperty from TransferTr…

…ackerDbMessage.java
nhsconnect · May 16, 2023 · 292a320 · 292a320
1 parent 2fe180a
commit 292a320
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 12 deletions.
diff --git a/src/test/java/uk/nhs/prm/deduction/e2e/tests/RepositoryE2ETests.java b/src/test/java/uk/nhs/prm/deduction/e2e/tests/RepositoryE2ETests.java
@@ -241,7 +241,6 @@ public void given2XMLsWithDifferences_whenTestsSimilarWithDifferenceEvaluator_th
 
     @Test
     void shouldVerifyThatALargeEhrXMLIsUnchanged() {
-
     }
 
     @Test

diff --git a/src/test/java/uk/nhs/prm/deduction/e2e/transfer_tracker_db/TrackerDb.java b/src/test/java/uk/nhs/prm/deduction/e2e/transfer_tracker_db/TrackerDb.java
@@ -48,8 +48,7 @@ public String waitForStatusMatching(String conversationId, String partialStatus)
                 .until(() -> transferTrackerDbClient.queryDbWithConversationId(conversationId).item().get("state").s(), containsString(partialStatus));
     }
 
-    public void save(TransferTrackerDbMessage message)
-    {
+    public void save(TransferTrackerDbMessage message) {
         transferTrackerDbClient.save(message);
     }
 }
diff --git a/src/test/java/uk/nhs/prm/deduction/e2e/transfer_tracker_db/TransferTrackerDbMessage.java b/src/test/java/uk/nhs/prm/deduction/e2e/transfer_tracker_db/TransferTrackerDbMessage.java
@@ -23,15 +23,15 @@ public class TransferTrackerDbMessage {
     private String createdAt;
     private String lastUpdatedAt;
 
-    public TransferTrackerDbMessage(@JsonProperty("conversationId") String conversationId,
-                                    @JsonProperty("largeEhrCoreMessageId") String largeEhrCoreMessageId,
-                                    @JsonProperty("nemsMessageId") String nemsMessageId,
-                                    @JsonProperty("nhsNumber") String nhsNumber,
-                                    @JsonProperty("sourceGp") String sourceGp,
-                                    @JsonProperty("state") String state,
-                                    @JsonProperty("nemsEventLastUpdated") String nemsEventLastUpdated,
-                                    @JsonProperty("createdAt") String createdAt,
-                                    @JsonProperty("lastUpdatedAt") String lastUpdatedAt){
+    public TransferTrackerDbMessage(String conversationId,
+                                    String largeEhrCoreMessageId,
+                                    String nemsMessageId,
+                                    String nhsNumber,
+                                    String sourceGp,
+                                    String state,
+                                    String nemsEventLastUpdated,
+                                    String createdAt,
+                                    String lastUpdatedAt){
         this.conversationId = conversationId;
         this.largeEhrCoreMessageId = largeEhrCoreMessageId;
         this.nemsMessageId = nemsMessageId;
-Original file line number
+Diff line change
@@ Expand Up @@
         @Test
         void shouldVerifyThatALargeEhrXMLIsUnchanged() {
         }
         @Test
@@ Expand Down @@