-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRMP-1257] Add log messages to adhere to audit requirements #479
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally happy with the PR. There are some very minor suggestions regarding inconsistent logging i.e some places HTTPVerb:
, others HTTP Verb:
, same with Nhs Number
and Nhs number
. Feel free to address if deemed appropriate, I am not too fussed with it.
url: str = "" | ||
size: int = 0 | ||
hash: str = "" | ||
title: str = "" | ||
creation: str = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change defaults to none instead
No description provided.