Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRMP-1257] Add log messages to adhere to audit requirements #479

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

steph-torres-nhs
Copy link
Contributor

No description provided.

Copy link
Contributor

@MohammadIqbalAD-NHS MohammadIqbalAD-NHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally happy with the PR. There are some very minor suggestions regarding inconsistent logging i.e some places HTTPVerb:, others HTTP Verb:, same with Nhs Number and Nhs number. Feel free to address if deemed appropriate, I am not too fussed with it.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
robg-nhs and others added 3 commits December 20, 2024 17:31

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Comment on lines -11 to -15
url: str = ""
size: int = 0
hash: str = ""
title: str = ""
creation: str = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change defaults to none instead

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants