[PRMP-839] Fixed suspended patient is active logic & added unit test #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyFlintNHS
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
reviewed
Aug 27, 2024
AndyFlintNHS
temporarily deployed
to
development
GitHub Actions
Inactive
NogaNHS
reviewed
Aug 29, 2024
lambdas/tests/unit/services/test_search_patient_details_service.py
Outdated
Show resolved
Hide resolved
NogaNHS
approved these changes
Aug 29, 2024
bethany-kish-nhs
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where any truthy value for the ODS code would cause a patient to be flagged as active. This caused a problem where PCSE couldn't view suspended patients as their 'ODS code' was returning as
SUSP, which is considered truthy and was incorrectly flagging them as active.Added a unit test with an example expected suspended patient response from PDS