PRMP-935 new lambda-generate-stitch-record #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbas-khan10
reviewed
Oct 8, 2024
|
|
||
| module "generate-stitch-record-lambda" { | ||
| source = "./modules/lambda" | ||
| name = "GenerateStitchRecord" |
There was a problem hiding this comment.
Can we call this GenerateLloydGeorgeStitch? So there is some consistency between this and the LloydGeorgeStitch lambda? Also it's a bit hard to tell which is responsible for creating the stitch job and Record is hard to differentiate between dynamo and patient records
abbas-khan10
reviewed
Oct 8, 2024
infrastructure/dynamo_db.tf
Outdated
| @@ -134,6 +134,38 @@ module "zip_store_reference_dynamodb_table" { | |||
| owner = var.owner | |||
| } | |||
|
|
|||
| module "stitch_store_reference_dynamodb_table" { | |||
There was a problem hiding this comment.
Can we change this name also, as there's isn't a Stitch Store bucket. Maybe LloydGeorgeStitchJobMetadata?
| @@ -72,19 +72,21 @@ module "delete-doc-ref-lambda" { | |||
| module.ndr-lloyd-george-store.s3_object_access_policy, | |||
| "arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole", | |||
| "arn:aws:iam::aws:policy/CloudWatchLambdaInsightsExecutionRolePolicy", | |||
| module.ndr-app-config.app_config_policy_arn | |||
| module.ndr-app-config.app_config_policy_arn, | |||
| module.stitch_metadata_reference_dynamodb_table.dynamodb_policy | |||
There was a problem hiding this comment.
Are we missing a depends on for these?
| @@ -55,7 +55,7 @@ module "generate-document-manifest-lambda" { | |||
| "arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole", | |||
| "arn:aws:iam::aws:policy/CloudWatchLambdaInsightsExecutionRolePolicy", | |||
| module.ndr-app-config.app_config_policy_arn, | |||
| aws_iam_policy.dynamodb_stream_policy.arn | |||
| aws_iam_policy.dynamodb_stream_manifest_policy.arn | |||
There was a problem hiding this comment.
Why does it need to be in depends_on??
chrisbloe
reviewed
Oct 17, 2024
infrastructure/dynamo_db.tf
Outdated
| source = "./modules/dynamo_db" | ||
| table_name = var.stitch_metadata_dynamodb_table_name | ||
| hash_key = "ID" | ||
| deletion_protection_enabled = false |
There was a problem hiding this comment.
Probably should be true?
chrisbloe
reviewed
Oct 17, 2024
chrisbloe
reviewed
Oct 17, 2024
| @@ -101,6 +103,7 @@ module "create-doc-ref-lambda" { | |||
| module.create-doc-ref-gateway, | |||
| module.ndr-app-config, | |||
| module.lloyd_george_reference_dynamodb_table, | |||
| module.document_reference_dynamodb_table | |||
| module.document_reference_dynamodb_table, | |||
| module.stitch_metadata_reference_dynamodb_table, | |||
chrisbloe
reviewed
Oct 17, 2024
| ] | ||
| } | ||
|
|
||
| resource "aws_iam_policy" "dynamodb_stream_policy" { | ||
| resource "aws_iam_policy" "dynamodb_stream_manifest_policy" { |
There was a problem hiding this comment.
If we're renaming this already, can it be called dynamodb_stream_manifest instead?
chrisbloe
reviewed
Oct 17, 2024
| APPCONFIG_APPLICATION = module.ndr-app-config.app_config_application_id | ||
| APPCONFIG_ENVIRONMENT = module.ndr-app-config.app_config_environment_id | ||
| APPCONFIG_CONFIGURATION = module.ndr-app-config.app_config_configuration_profile_id | ||
| LLOYD_GEORGE_BUCKET_NAME = "${terraform.workspace}-${var.lloyd_george_bucket_name}" |
chrisbloe
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.