-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if tutorials are originally in markdown, they don't get converted #12
Comments
This isn't as much of a problem when deployed on github pages now because it'll auto-render markdown now, but means that it looks a bit different than everything else. |
I missed this problem. Thanks. |
I have a fix for the null check. |
@minkyu-yi For rendering out the markdown tutorials, what about updating the article in the tutorial.tmpl to either output an iframe for the html page or render out the markdown inline? Then, the styles are easily available for the markdown without any extra work. |
Sweet! Yeah, I'll take a look in the next couple of days. |
Uses the TUI JSDoc template. All configuring of jsdoc was moved to the jsdoc.json file. There's currently a bug with TUI regarding the tutorials (nhn/tui.jsdoc-template#12) but it should via gh-pages currently because it'll now autorender markdown into html.
When using this template, if the tutorials are in markdown, they just get copied to the destination directory's
tutorials/
folder without conversion.Also, if tutorials aren't configured as a config option, this template will fail because there's no null check here https://github.com/nhnent/tui.jsdoc-template/blob/master/publish.js#L718.
I'll probably look into this tomorrow, but wanted to post an issue about it first.
The text was updated successfully, but these errors were encountered: