Add experiment to skip waiting until all updates of collection/table …

…view are committed in -accessibilityElements The wait was introduced in TextureGroup#1217 which blocks the main thread until updates are proccessed. We suspect this causes perf regressions accross the app and need to confirm this via an experiment.
nguyenhuy · Jan 11, 2019 · f8ef2f9 · f8ef2f9
1 parent 2d43f46
commit f8ef2f9
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 7 deletions.
diff --git a/Schemas/configuration.json b/Schemas/configuration.json
@@ -19,10 +19,12 @@
                     "exp_unfair_lock",
                     "exp_infer_layer_defaults",
                     "exp_network_image_queue",
-                    "exp_dealloc_queue_v2",
                     "exp_collection_teardown",
                     "exp_framesetter_cache",
-                    "exp_skip_clear_data"
+                    "exp_skip_clear_data",
+                    "exp_did_enter_preload_skip_asm_layout",
+                    "exp_disable_a11y_cache",
+                    "exp_skip_a11y_wait"
                 ]
     		}
 		}

diff --git a/Source/ASCollectionView.mm b/Source/ASCollectionView.mm
@@ -2465,7 +2465,9 @@ - (void)setPrefetchingEnabled:(BOOL)prefetchingEnabled
 
 - (NSArray *)accessibilityElements
 {
-  [self waitUntilAllUpdatesAreCommitted];
+  if (!ASActivateExperimentalFeature(ASExperimentalSkipAccessibilityWait)) {
+    [self waitUntilAllUpdatesAreCommitted];
+  }
   return [super accessibilityElements];
 }
 

diff --git a/Source/ASExperimentalFeatures.h b/Source/ASExperimentalFeatures.h
@@ -29,6 +29,7 @@ typedef NS_OPTIONS(NSUInteger, ASExperimentalFeatures) {
   ASExperimentalSkipClearData = 1 << 8,                     // exp_skip_clear_data
   ASExperimentalDidEnterPreloadSkipASMLayout = 1 << 9,      // exp_did_enter_preload_skip_asm_layout
   ASExperimentalDisableAccessibilityCache = 1 << 10,        // exp_disable_a11y_cache
+  ASExperimentalSkipAccessibilityWait = 1 << 11,            // exp_skip_a11y_wait
   ASExperimentalFeatureAll = 0xFFFFFFFF
 };
 

diff --git a/Source/ASExperimentalFeatures.mm b/Source/ASExperimentalFeatures.mm
@@ -22,7 +22,8 @@
                                       @"exp_framesetter_cache",
                                       @"exp_skip_clear_data",
                                       @"exp_did_enter_preload_skip_asm_layout",
-                                      @"exp_disable_a11y_cache"]));
+                                      @"exp_disable_a11y_cache",
+                                      @"exp_skip_a11y_wait"]));
 
   if (flags == ASExperimentalFeatureAll) {
     return allNames;

diff --git a/Source/ASTableView.mm b/Source/ASTableView.mm
@@ -2004,7 +2004,9 @@ - (void)didMoveToSuperview
 
 - (NSArray *)accessibilityElements
 {
-  [self waitUntilAllUpdatesAreCommitted];
+  if (!ASActivateExperimentalFeature(ASExperimentalSkipAccessibilityWait)) {
+    [self waitUntilAllUpdatesAreCommitted];
+  }
   return [super accessibilityElements];
 }
 

diff --git a/Tests/ASConfigurationTests.mm b/Tests/ASConfigurationTests.mm
@@ -28,7 +28,8 @@
   ASExperimentalFramesetterCache,
   ASExperimentalSkipClearData,
   ASExperimentalDidEnterPreloadSkipASMLayout,
-  ASExperimentalDisableAccessibilityCache
+  ASExperimentalDisableAccessibilityCache,
+  ASExperimentalSkipAccessibilityWait,
 };
 
 @interface ASConfigurationTests : ASTestCase <ASConfigurationDelegate>
@@ -51,7 +52,8 @@ + (NSArray *)names {
     @"exp_framesetter_cache",
     @"exp_skip_clear_data",
     @"exp_did_enter_preload_skip_asm_layout",
-    @"exp_disable_a11y_cache"
+    @"exp_disable_a11y_cache",
+    @"exp_skip_a11y_wait"
   ];
 }