Modify rpc_completed_slot_service to be non-blocking (solana-labs#24007)

* timeout for validator exits * clippy * print backtrace when panic * add backtrace package * increase time out to 30s * debug logging * make rpc complete service non blocking * reduce log level * remove logging * recv_timeout * remove backtrace * remove sleep * remove unused variable * add comments * Update core/src/validator.rs Co-authored-by: Trent Nelson <[email protected]> * Update core/src/validator.rs Co-authored-by: Trent Nelson <[email protected]> * whitespace * more whitespace * fix build Co-authored-by: Trent Nelson <[email protected]>
ngundotra · Apr 2, 2022 · 6128b0c · 6128b0c
1 parent 72577b8
commit 6128b0c
Showing 1 changed file with 7 additions and 14 deletions.
diff --git a/rpc/src/rpc_completed_slots_service.rs b/rpc/src/rpc_completed_slots_service.rs
@@ -26,26 +26,19 @@ impl RpcCompletedSlotsService {
         Builder::new()
             .name("solana-rpc-completed-slots-service".to_string())
             .spawn(move || loop {
-                // received exit signal, shutdown the service
+                // shutdown the service
                 if exit.load(Ordering::Relaxed) {
                     break;
                 }
 
-                match completed_slots_receiver
+                if let Ok(slots) = completed_slots_receiver
                     .recv_timeout(Duration::from_millis(COMPLETE_SLOT_REPORT_SLEEP_MS))
                 {
-                    Err(RecvTimeoutError::Timeout) => {}
-                    Err(RecvTimeoutError::Disconnected) => {
-                        info!("RpcCompletedSlotService channel disconnected, exiting.");
-                        break;
-                    }
-                    Ok(slots) => {
-                        for slot in slots {
-                            rpc_subscriptions.notify_slot_update(SlotUpdate::Completed {
-                                slot,
-                                timestamp: timestamp(),
-                            });
-                        }
+                    for slot in slots {
+                        rpc_subscriptions.notify_slot_update(SlotUpdate::Completed {
+                            slot,
+                            timestamp: timestamp(),
+                        });
                     }
                 }
             })