-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /usr/local and /opt/homebrew #668
Comments
Thanks! This will take some time to fix as I'll need to reproduce the issues that caused me to add this and solve them somehow differently. |
Presumably you were building ngs from source and you wanted to use dependencies installed with Homebrew on Apple Silicon. (On Intel, Homebrew installs to /usr/local which as I said compilers use by default.) The solution would be to specify the |
Sounds about right. Still need to check though. |
Fixed in |
This code is wrong, or at least partly unnecessary and partly inconvenient:
ngs/CMakeLists.txt
Lines 24 to 25 in dd1bc70
/usr/local does not need to be mentioned here because compilers look in /usr/local by default.
/opt/homebrew should not be mentioned here because the user may not be using Homebrew or may not want to use its software.
For example, a user installing ngs without Homebrew installed will see the warning:
Another example: if a user is installing ngs with MacPorts, but they also happen to have Homebrew installed (which MacPorts does not support and strongly discourages but some users can't help themselves), then they definitely do not want ngs's dependencies to be satisfied by things installed using Homebrew.
The text was updated successfully, but these errors were encountered: