This repository has been archived by the owner on Jan 10, 2018. It is now read-only.
Fix v2 contrib #330
Closed
Fix v2 contrib #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes have been implemented in the monorepo where we are migrating the packages: https://github.com/ngrx/platform |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, contributions to master seems to be frozen, waiting for the resolution of #269, which should be released with ngrx/store v3 along with Angular 4 (release planned for march / april 2017).
In the mean time, unit tests doesn't run on the current version (see #321). In order to fix that, and to permit minor features and patch for the v2, this PR "cherry-picked" one of MikeRyan52 commits from #269, and update the CONTRIBUTING documentation.
#319 is deprecated by this PR