fix(*): packages are being bundled twice

[alan-agius4]

Remove JavaScript from src folder as this is not required by the consumers with Angular 4.x.x, @ngtools/webpack and paths in tsconfig.json it causes the src to be bundled togather with the FESM.

Closes: #629

[coveralls]

Coverage remained the same at 92.274% when pulling 5aec884 on alan-agius4:feature/fix-double-bundle into 2fbcd24 on ngrx:master.

[brandonroberts]

I'm still not inclined to merge this as seems like a configuration issue with the bundler. I've used NGRX V4 with Angular 4 and webpack wth no issues. Maybe @TheLarkInn can weigh in?

[alan-agius4]

The problem is when you use NGRX 4, Angular 4 and Paths options in TSConfig.

NGC 4 reaolved the paths of the source files next to the .d.ts files instead of using the package.json if paths options is specified in the ts config.

This is no longer a problem in NG5 because Angular change how files are resolved, as they now rely on TypeScript to do the resolution.

It’s not the bundler that is resolving the files incorrectly but rather NGC, that said you are still shipping js files which in theory shouldn’t be present in the distributable as consumers shouldn’t be using, so why not delete them really? Will even make the final package smaller when downloading in npm.

So really this PR, fixes a bug, removes uneeded files from the distributable, and align your final package format with Google’s ‘Angular Package Format V 4.0’.

[brandonroberts]

Good points, but I'm not going to introduce what could be a breaking change for many existing users to handle this edge case. We'll look at changing this in the next major release.

[alan-agius4]

Can you explain why this is a breaking change? Bundlers are still unable to pick up these sources because they are not listed in the package.json

[brandonroberts]

It could be a breaking change, mainly for consumers who are reaching into the source files but you shouldn't be doing that anyway. If it affects someone using the nightlies, they will chime in. Thanks for your patience.

[alan-agius4]

Thank you

…

On Wed, 06 Dec 2017 at 19:31, Brandon ***@***.***> wrote: Merged #630 <#630>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#630 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-Wi2OP2pPd8jTMooZo9BfQJ3ZQ3I-ks5s9t1qgaJpZM4Q2fVD> .