Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): make action props plural #4017

Merged
merged 4 commits into from
Sep 2, 2023
Merged

fix(schematics): make action props plural #4017

merged 4 commits into from
Sep 2, 2023

Conversation

michaelxvoelker
Copy link
Contributor

@michaelxvoelker michaelxvoelker commented Aug 24, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The reducer uses the plural form for the action property of add and upsert actions, though the definitions of the actions use the singular form. This results in errors.

Originally found by @manfredsteyer in a workshop.

What is the new behavior?

add and upsert actions define their properties in plural form

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 0fdeb67
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64f1e7710223f200086aaa28

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@markostanimirovic
Copy link
Member

Thanks @michaelxvoelker!

@markostanimirovic markostanimirovic merged commit 3a56412 into ngrx:main Sep 2, 2023
@michaelxvoelker
Copy link
Contributor Author

You're welcome 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants