-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(component-store): Add SelectorObject to select
#3629
Conversation
✅ Deploy Preview for ngrx-io canceled.
|
Looks like update of
|
There's a similar stackoverflow issue: https://stackoverflow.com/questions/73638281/jest-throws-typeerror-cannot-read-properties-of-undefined-reading-isfake |
I'll use |
Here is my full suggestion for the Let me know what you think :) |
I see. Thanks Marko! I kept your suggestion to keep the operators inlined in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Adds
selectorsObject
or an Object that maps properties to selectors (or other Observables) and a new API to theselect
method.What is the current behavior?
Closes #3624
What is the new behavior?
Does this PR introduce a breaking change?
Other information