Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): migration for provideEffects argument #3601

Merged
merged 4 commits into from
Oct 22, 2022

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Adds a migration for #3587

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@timdeschryver timdeschryver changed the title Feat/provide effects migration feat(effects): migration for provideEffects argument Oct 11, 2022
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 84eb7b0
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/635286acd655270009ea6dd1

Copy link
Member Author

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonroberts the test now also contains effects that are provided in the route config

@brandonroberts brandonroberts merged commit f7dfeab into master Oct 22, 2022
@timdeschryver timdeschryver deleted the feat/provideEffects-migration branch October 23, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants