-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(component): use RenderScheduler as a service #3493
Merged
timdeschryver
merged 3 commits into
ngrx:master
from
markostanimirovic:refactor/component/render-scheduler
Aug 5, 2022
Merged
refactor(component): use RenderScheduler as a service #3493
timdeschryver
merged 3 commits into
ngrx:master
from
markostanimirovic:refactor/component/render-scheduler
Aug 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
markostanimirovic
force-pushed
the
refactor/component/render-scheduler
branch
2 times, most recently
from
July 18, 2022 23:33
5aa2354
to
a5cfe3f
Compare
markostanimirovic
force-pushed
the
refactor/component/render-scheduler
branch
from
July 25, 2022 22:29
a5cfe3f
to
ddacaa0
Compare
markostanimirovic
force-pushed
the
refactor/component/render-scheduler
branch
from
August 2, 2022 21:50
ddacaa0
to
6502da9
Compare
brandonroberts
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
return { schedule }; | ||
export function createRenderScheduler(): RenderScheduler { | ||
return new RenderScheduler(inject(ChangeDetectorRef), inject(TickScheduler)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
timdeschryver
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts
RenderScheduler
to a service, so it could be also used in the following way:PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information
This PR currently depends on #3488