Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-store): allow void callbacks in effect #3466

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3462

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jun 22, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 8c2e601
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62b33bab7eb2490009cd216a
😎 Deploy Preview https://deploy-preview-3466--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@alex-okrushko alex-okrushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, thanks Tim! 👍

Interesting use case :)

@brandonroberts brandonroberts merged commit e6dedd6 into master Jun 28, 2022
@brandonroberts brandonroberts deleted the cs/effect-void-callback branch June 28, 2022 20:51
@melcor76
Copy link

melcor76 commented Oct 5, 2022

Thanks @timdeschryver!
This has caused us unexpected bugs on multiple occasions before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component-store: An effect declared with type void does not accept a void observable
4 participants