Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): improve install flow #3447

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Improvements after I tried to install the beta version of NgRx ESLint:

  • Only install the plugin if an ESLint config exists
  • Rephrased the prompt to select the configuration to make it explicit that it's about the ESLint config

@netlify
Copy link

netlify bot commented Jun 6, 2022

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit de1b91f
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/629ddfbac542c80008e4aecc
😎 Deploy Preview https://deploy-preview-3447--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@markostanimirovic markostanimirovic merged commit 8ddaf60 into master Jun 6, 2022
@markostanimirovic markostanimirovic deleted the eslint-improvement branch June 6, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants