Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feature_creator.ts #3198

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Update feature_creator.ts #3198

merged 2 commits into from
Oct 23, 2021

Conversation

bryantlikes
Copy link
Contributor

Fixing feature creator to use the version of createFeatureSelector without the RootState.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ X ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Uses the createFeatureSelector version that uses RootState which conflicts with the recommended usage.

Closes #3197

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ X ] No

Other information

Fixing feature creator to use the version of createFeatureSelector without the RootState.
@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 22, 2021

Preview docs changes for 22cc646 at https://previews.ngrx.io/pr3198-22cc6461/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great, if we can refactor all these usages.
If I'm not mistaken, there are 2 usages left after this one, both in the examples.
You can search for export const selectCollectionState = createFeatureSelector< and you'll find them.
Could you add these to this PR please?

@bryantlikes
Copy link
Contributor Author

@timdeschryver updated the two instances I found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like createFeature should also be updated to not use this version of createFeatureSelector?
4 participants