Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(createSelector): Ability to test the projectorFn independent from the selectors it is composed of #291

Merged
merged 3 commits into from
Aug 20, 2017
Merged

feat(createSelector): Ability to test the projectorFn independent from the selectors it is composed of #291

merged 3 commits into from
Aug 20, 2017

Conversation

03byron
Copy link
Contributor

@03byron 03byron commented Aug 17, 2017

fixes #290

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.221% when pulling 7deeedd on 03byron:master into bf7f70c on ngrx:master.

MikeRyanDev
MikeRyanDev reviewed Aug 20, 2017
View reviewed changes
modules/store/src/selector.ts Outdated
export interface MemoizedSelector<State, Result>
extends Selector<State, Result> {
release(): void;
resultFunc: AnyFn;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this projector instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. Just updated it accordingly.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.221% when pulling a159721 on 03byron:master into bf7f70c on ngrx:master.

@MikeRyanDev MikeRyanDev merged commit 56cb21f into ngrx:master Aug 20, 2017
@MikeRyanDev
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRyanDev MikeRyanDev MikeRyanDev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to test the projectorFn of createSelector() independent from the selectors it is composed of
4 participants
@03byron @coveralls @MikeRyanDev @pixbyron