Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(effects): add test cases for effect factory #2818

Conversation

moniuch
Copy link
Contributor

@moniuch moniuch commented Dec 10, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Additional test cases for effects factory syntax

What is the current behavior?

Adding a few cases to cover the createEffect factory syntax.

Closes #2817

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Dec 10, 2020

Preview docs changes for c1effe5 at https://previews.ngrx.io/pr2818-c1effe52/

@brandonroberts brandonroberts removed the request for review from alex-okrushko December 12, 2020 01:49
@brandonroberts brandonroberts merged commit 705ae44 into ngrx:master Dec 12, 2020
@moniuch moniuch deleted the feature/test-cases-for-parameterized-effects-syntax branch December 13, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

effects: Add test cases to cover the createEffect factory syntax
4 participants