fix(Store): Add type signature for metareducer #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Feel free to merge once the build turns green. |
brandonroberts
force-pushed
the
metareducer-type
branch
from
dc59b3b to
541aae0
Compare
brandonroberts
added a commit
that referenced
this pull request
Aug 16, 2017
This reverts commit 57633d2.
nhaesler
added a commit
to nhaesler/ngrx-store-localstorage
that referenced
this pull request
Sep 26, 2017
ngrx/platform#270 (landed in store 4.0.3) changed the type signature of the meta reducers array. This fixes the resulting type conflict with the usage example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the type signature issue for the array of metareducers. Each function should take a reducer and return a new reducer function.
Closes #264, Related to #170