Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(store): Refined step 6,7, and 8 of getting started guide to be m… #2627

Merged

Conversation

ptouchton
Copy link
Contributor

@ptouchton ptouchton commented Jul 21, 2020

…ore detailed.

closes #1880

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x ] Documentation content changes
[ ] Other... Please describe:

Closes #1880

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 21, 2020

Preview docs changes for 19a79d4 at https://previews.ngrx.io/pr2627-19a79d4c/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ptouchton
I do have one question about the changes to the examples.

projects/ngrx.io/content/examples/ngrx-start/src/main.ts Outdated Show resolved Hide resolved
@ptouchton ptouchton force-pushed the getting-started-guide-refactor branch from 72b15e2 to 19a79d4 Compare July 23, 2020 14:01
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@brandonroberts brandonroberts merged commit b144ed9 into ngrx:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started - Step 6 is overloaded
4 participants