docs: fix selection of state using arrow function #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select method from the Store expects a function, when I put the `this.counter = store.select<number>('counter');` the compiler says: `Argument of type '"counter"' is not assignable to parameter of type '(state: AppState) => string'.`
docs/store/README.md
Outdated
| @@ -96,7 +96,7 @@ export class MyAppComponent { | |||
| counter: Observable<number>; | |||
|
|
|||
| constructor(private store: Store<AppState>) { | |||
| this.counter = store.select<number>('counter'); | |||
| this.counter = store.select<number>((state: AppState) => state.counter); | |||
There was a problem hiding this comment.
Don't remove the string selector, remove the <number> type instead. You can't use the generic type with the string selector, which is the cause for the error.
There was a problem hiding this comment.
You were right @brandonroberts , I guess it is easier for new comers to select state using the string selector instead of the callback.
The generic type is not necessary and causes error in compilation because it expects the state key instead of the state key type.
brandonroberts
approved these changes
Aug 11, 2017
|
Thanks! |
brandonroberts
added a commit
that referenced
this pull request
Aug 16, 2017
…)" This reverts commit ca544dd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The select method from the Store expects a function, when I put the
this.counter = store.select<number>('counter');the compiler says:Argument of type '"counter"' is not assignable to parameter of type '(state: AppState) => string'.