Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(component-store): fix movies$ observable assignment #2587

Merged

Conversation

ngfelixl
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No changes in the behaviour, just a tiny doc change. The assignment of the movie$ observable was made as a type definition movie$: this.store...., but should be movie$ = this.store....

What is the new behavior?

The assignment is made as movie$ = this.store...

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 17, 2020

Preview docs changes for ef614f7 at https://previews.ngrx.io/pr2587-ef614f7e/

@timdeschryver timdeschryver changed the title docs(component-store): fix movie$ observable assignment docs(component-store): fix movies$ observable assignment Jun 17, 2020
@timdeschryver timdeschryver merged commit e3b178d into ngrx:master Jun 17, 2020
@timdeschryver
Copy link
Member

Thanks @ngfelixl !

@alex-okrushko
Copy link
Member

Thanks! 🙂

@ngfelixl ngfelixl deleted the docs/fix-component-store-example branch June 17, 2020 20:36
@ngfelixl
Copy link
Contributor Author

ngfelixl commented Jun 18, 2020

I have to thank you, for mentioning me twice at ng-conf because of the router-store schematics implementation.

@timdeschryver, @alex-okrushko Is there anything else I can support you with related to NgRX? Are there any intermediate issues that I could tackle not being labelled as "good-first-issue"? Is there anything I can do to support you besides coding as well?

In order to place me somewhere, it might be good if you get a brief introduction about me: I am a developer focusing on web technologies. A lot of projects I led use Angular, NgRX and RxJS and I also recommend these frameworks for many projects frequently. Regularly I also give trainings for these technologies to our clients. The insight into the frameworks source code could be improved.
Thanks in advance!

BioPhoton pushed a commit to BioPhoton/platform that referenced this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants