Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compare function is used in two places, neither of which expect it to be able to return a string:
The first caller is the Array prototype sort function, and there it "should return a negative, zero, or positive value, depending on the arguments".
The second caller does a numerical comparison with the result.
Even though an id can be a string, the result of a comparison shouldn't be.
This might be a breaking change.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
According to the typing, a sortComparer can return a string, but it would be a mistake to allow that. Even though an id can be a string, the result of a comparison shouldn't be.
Closes #
What is the new behavior?
Remove the ComparerStr option for Comparar.
Does this PR introduce a breaking change?
Functions that return a string instead of a number would not compile. The user would need to fix the comparer.
Other information