Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): use Angular default properties when not defined #2507

Merged
merged 2 commits into from
May 4, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1036(comment)

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

By removing the default values in the schema, we can remove the undefined values before we pass them to the Angular component schematic. By doing this, Angular will replace the undefined values with the defaults set in angular.json. If no default value is provided in the angular.json file, it will use the defaults from the Angular schematic schema.

I tried to write a test for it but it seems like during the tests, the transformer isn't included.

@brandonroberts brandonroberts merged commit 7cd0624 into master May 4, 2020
@brandonroberts brandonroberts deleted the pr/container-schematics-angular-defaults branch May 4, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After add @ngrx/schematics to ng6 project, cli generate component with css instead of scss
2 participants