fix(data): make undoMany remove tracking changes in changeState (#2346) #2352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2346
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
UNDO_ONE and UNDO_MANY actions reverts one/many entities back to their original state but changeState keeps the tracking the entity/entities.
Closes #2346
What is the new behavior?
UNDO_ONE and UNDO_MANY actions remove the entity/entities from changeState as well as the current behavior of reverting the entities state.
Does this PR introduce a breaking change?
Other information
This would be my first ever PR if accepted.
Please confirm if PR is intended behavior before accepting.
Reference https://ngrx.io/guide/data/entity-change-tracker#removing-an-entity-from-the-changestate-map