Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): improve createFeatureSelector warning #2163

Merged
merged 2 commits into from
Oct 14, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2116

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 10, 2019

Preview docs changes for 3ba1897 at https://previews.ngrx.io/pr2163-3ba1897/

@brandonroberts brandonroberts merged commit e4765d6 into master Oct 14, 2019
@brandonroberts brandonroberts deleted the pr/createFeatureSelector-warnings branch October 14, 2019 02:24
@jtcrowson
Copy link
Contributor

This is awesome @timdeschryver! Thank you 🎉

@timdeschryver
Copy link
Member Author

It was a team effort @jtcrowson 💪

jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New warning about unprovided feature state wrecks unit test output
5 participants