Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(store): change alert to mention auto cleanup #2132

Merged
merged 3 commits into from
Oct 1, 2019
Merged

docs(store): change alert to mention auto cleanup #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f16677d
docs(store): change alert to mention auto cleanup
timdeschryver Sep 27, 2019
fed9c86
example: remove resetSelectors
timdeschryver Sep 27, 2019
8755a91
Update projects/ngrx.io/content/guide/store/testing.md
timdeschryver Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions projects/ngrx.io/content/examples/testing-store/src/app/auth-guard.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,4 @@ describe('Auth Guard', () => {

expect(guard.canActivate()).toBeObservable(expected);
});

afterAll(() => store.resetSelectors());
});
2 changes: 1 addition & 1 deletion projects/ngrx.io/content/guide/store/testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ In this example, we mock the `getLoggedIn` selector by using `overrideSelector`,

<div class="alert is-helpful">

**Note:** Reset overridden selectors using the `MockStore.resetSelectors()` method to prevent other tests from using the overridden selector value. This is shown in the above example.
**Note:** `MockStore` will reset all of the mocked selectors after each test (in the `afterEach()` hook) by calling the `MockStore.resetSelectors()` method.

</div>

Expand Down