Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Use MockStore in container generated tests #2029

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Schematics: Use MockStore in container generated tests #2029

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
999e71e
refactor(schematics): Update container schematic to generate test fil…
Jul 21, 2019
68facda
refactor(schematics): Update container schematic tests to expect test…
Jul 22, 2019
689fc93
refactor(schematics): Revert change to Store TestBed init
Jul 22, 2019
896899c
feat(schematics): Add option to customize test depth between Unit or …
Jul 24, 2019
b696b66
feat(docs): Add documentation for testDepth container option
Jul 24, 2019
b088215
refactor(schematics): use lowercase enum and update default to be int…
Jul 31, 2019
d713cbe
chore: add integration files to Bazel build configuration
brandonroberts Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .../container/files/__name@dasherize@if-flat__/__name@dasherize__.component.spec.ts.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';

import { <%= classify(name) %>Component } from './<%= dasherize(name) %>.component';
import { Store, StoreModule } from '@ngrx/store';
import { provideMockStore, MockStore } from '@ngrx/store/testing';

describe('<%= classify(name) %>Component', () => {
let component: <%= classify(name) %>Component;
let fixture: ComponentFixture<<%= classify(name) %>Component>;
let store: Store<any>;
let store: MockStore<any>;

beforeEach(async() => {
TestBed.configureTestingModule({
imports: [ StoreModule.forRoot({}) ],
providers: [ provideMockStore() ],
declarations: [ <%= classify(name) %>Component ]
});

Expand All @@ -20,9 +20,8 @@ describe('<%= classify(name) %>Component', () => {
beforeEach(() => {
fixture = TestBed.createComponent(<%= classify(name) %>Component);
component = fixture.componentInstance;
store = TestBed.get<Store>(Store);
store = TestBed.get(Store);
jtcrowson marked this conversation as resolved.
Show resolved Hide resolved

spyOn(store, 'dispatch').and.callThrough();
fixture.detectChanges();
});

Expand Down
15 changes: 13 additions & 2 deletions modules/schematics/src/container/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,21 @@ describe('Container Schematic', () => {
`${projectPath}/src/app/foo/foo.component.spec.ts`
);
expect(content).toMatch(
/import { Store, StoreModule } from '@ngrx\/store';/
/import { provideMockStore, MockStore } from '@ngrx\/store\/testing';/
);
});

it('should use the provideMockStore helper', async () => {
const options = { ...defaultOptions, spec: true };
const tree = await schematicRunner
.runSchematicAsync('container', options, appTree)
.toPromise();
const content = tree.readContent(
`${projectPath}/src/app/foo/foo.component.spec.ts`
);
expect(content).toMatch(/providers: \[ provideMockStore\(\) \]/);
});

it('should inject Store correctly', async () => {
const options = { ...defaultOptions, spec: true };
const tree = await schematicRunner
Expand All @@ -130,6 +141,6 @@ describe('Container Schematic', () => {
const content = tree.readContent(
`${projectPath}/src/app/foo/foo.component.spec.ts`
);
expect(content).toMatch(/store = TestBed\.get<Store>\(Store\);/);
expect(content).toMatch(/store = TestBed\.get\(Store\);/);
});
});