Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix module import (#1930) #1932

Merged
merged 2 commits into from
Jun 10, 2019
Merged

docs: fix module import (#1930) #1932

merged 2 commits into from
Jun 10, 2019

Conversation

pegaltier
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

only doc

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ X] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1930

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 8, 2019

Preview docs changes for f71e624 at https://previews.ngrx.io/pr1932-f71e624/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another NgRxDataModule.forRoot at the bottom of the page, could you also catch that one please?

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 8, 2019

Preview docs changes for de552f9 at https://previews.ngrx.io/pr1932-de552f9/

@brandonroberts brandonroberts merged commit 878d31c into ngrx:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect ngrx/data module on ngrx.io/guide
4 participants