docs: add exported reducer function to createReducer examples #1924
Conversation
|
Preview docs changes for d20221f at https://previews.ngrx.io/pr1924-d20221f/ |
|
|
||
| export function reducer(state: State | undefined: action: Action) { | ||
| return scoreboardReducer(state, action); | ||
| } |
There was a problem hiding this comment.
This will only work for StoreModule.forFeature or for ReducerActionMap. I think we should recommend combineReducers way if there are more than a single reducer.
There was a problem hiding this comment.
Agreed. I think that should be an additional section to talk about combineReducers
There was a problem hiding this comment.
Haven't found any. Is it somewhere I missed? :)
There was a problem hiding this comment.
@maxime1992 there's an open issue - #1179
| @@ -64,26 +65,42 @@ The initial values for the `home` and `away` properties of the state are 0. | |||
|
|
|||
| ### Creating the reducer function | |||
|
|
|||
| The reducer function's responsibility is to handle the state transitions in an immutable way. Define a reducer function that handles the actions for managing the state of the scoreboard. | |||
There was a problem hiding this comment.
I can't highlight it but on line 15, we define the reducer function with - The switch statement
brandonroberts
force-pushed
the
docs-reducer-creators
branch
from
d20221f to
d3d01b1
Compare
|
Preview docs changes for d3d01b1 at https://previews.ngrx.io/pr1924-d3d01b1/ |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #1762
What is the new behavior?
Does this PR introduce a breaking change?
Other information