Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example): use barrel import for core module #1869

Merged
merged 2 commits into from
May 20, 2019

Conversation

jasonhodges
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

relates to #1808

Closes #

What is the new behavior?

This PR introduces barrel imports for core module and its sub-folders.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 17, 2019

Preview docs changes for 82eeba8 at https://previews.ngrx.io/pr1869-82eeba8/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 17, 2019

Preview docs changes for 47b1853 at https://previews.ngrx.io/pr1869-47b1853/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jasonhodges 👍

@brandonroberts brandonroberts merged commit 29c426b into ngrx:master May 20, 2019
@jasonhodges jasonhodges deleted the pr/core-barrel-imports branch May 20, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants