-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(effects): add mapToAction operator #1822
Conversation
Preview docs changes for 29e89c6 at https://previews.ngrx.io/pr1822-29e89c6/ |
Waiting for #1795 to be merged, so I can adjust the path of |
Preview docs changes for 388ca02 at https://previews.ngrx.io/pr1822-388ca02/ |
Preview docs changes for 96654cf at https://previews.ngrx.io/pr1822-96654cf/ |
@alex-okrushko - should this include a README or docs on (a) Benefits and (b) How to use it ? |
Preview docs changes for 946f828 at https://previews.ngrx.io/pr1822-946f828/ |
FYI, I'm adding docs for this PR ATM. |
Preview docs changes for 43cba13 at https://previews.ngrx.io/pr1822-43cba13/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback on the docs
Co-Authored-By: Tim Deschryver <[email protected]>
Co-Authored-By: Tim Deschryver <[email protected]>
Co-Authored-By: Tim Deschryver <[email protected]>
Co-Authored-By: Tim Deschryver <[email protected]>
Preview docs changes for 2629f1a at https://previews.ngrx.io/pr1822-2629f1a/ |
Preview docs changes for bfce944 at https://previews.ngrx.io/pr1822-bfce944/ |
Preview docs changes for 090e6c9 at https://previews.ngrx.io/pr1822-090e6c9/ |
Preview docs changes for bfce944 at https://previews.ngrx.io/pr1822-bfce944/ |
Preview docs changes for 090e6c9 at https://previews.ngrx.io/pr1822-090e6c9/ |
Preview docs changes for c5e6f99 at https://previews.ngrx.io/pr1822-c5e6f99/ |
1 similar comment
Preview docs changes for c5e6f99 at https://previews.ngrx.io/pr1822-c5e6f99/ |
Preview docs changes for f248946 at https://previews.ngrx.io/pr1822-f248946/ |
Preview docs changes for 2369f9e at https://previews.ngrx.io/pr1822-2369f9e/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Introduces
mapToAction
operator that can take either the config object, or 2 parameters: project and error.config has the following interface:
What is the current behavior?
Closes # #1224
What is the new behavior?
Does this PR introduce a breaking change?
Other information