Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schematics): type actions and avoid endless loop in effect #1576

Merged
merged 1 commit into from
Feb 26, 2019
Merged

fix(schematics): type actions and avoid endless loop in effect #1576

merged 1 commit into from
Feb 26, 2019

Conversation

fmalcher
Copy link
Contributor

Two minor fixes for effects generated by ng g feature:

  • Make the generated effect for 'ng g feature' harmless by not dispatching any action
  • type the 'Actions' injectable by default in feature effect

Closes #1573

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

coveralls commented Feb 21, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 89.527% when pulling 9115c3e on fmalcher:fix-schematics-effectloop into 63b6ff9 on ngrx:master.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 21, 2019

Preview docs changes for 1afec52 at https://previews.ngrx.io/pr1576-1afec52/

1 similar comment
@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 21, 2019

Preview docs changes for 1afec52 at https://previews.ngrx.io/pr1576-1afec52/

@fmalcher
fix(schematics): type actions and avoid endless loop in effect
9115c3e 
Make the generated effect for 'ng g feature'  harmless by not dispatching any action
type the 'Actions' injectable by default in effect

Closes #1573
@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 22, 2019

Preview docs changes for 9115c3e at https://previews.ngrx.io/pr1576-9115c3e/

@brandonroberts brandonroberts merged commit 5fbcb3c into ngrx:master Feb 26, 2019
tja4472 pushed a commit to tja4472/platform that referenced this pull request Mar 20, 2019
@fmalcher @tja4472
fix(schematics): type actions and avoid endless loop in effect schema…
a4dfbbe 
…tic (ngrx#1576)

- Make the generated effect for 'ng g feature'  harmless by not dispatching any action.
- Type the 'Actions' Injectable by default in effect

Closes ngrx#1573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schematics: Default effect leads to an endless loop
5 participants
@fmalcher @coveralls @ngrxbot @brandonroberts @timdeschryver