Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json) watch:tests script to work with Windows #1560

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

tja4472
Copy link
Contributor

@tja4472 tja4472 commented Feb 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

yarn run watch:tests script does not work on Windows.

PS C:\VSCode\2019\git-hub-forks\platform> yarn run watch:tests
yarn run v1.13.0
$ chokidar 'modules/**/*.ts' --initial -c 'yarn run test:unit'
Watching "'modules/**/*.ts'", "run", "test:unit'" ..
Terminate batch job (Y/N)? y

Closes #
#1559

What is the new behavior?

PS C:\VSCode\2019\temp\platform-rex> yarn run watch:tests
yarn run v1.13.0
$ chokidar "modules/**/*.ts" --initial --command "yarn run test:unit"
add:modules\entity\index.ts
add:modules\entity\public_api.ts
add:modules\effects\index.ts

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.43% when pulling b072185 on tja4472:issue-1559 into e07ae3d on ngrx:master.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 16, 2019

Preview docs changes for b072185 at https://previews.ngrx.io/pr1560-b072185/

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants