refactor(schematics): add project keys to schema #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing project keys to schema.json for store, store-devtools and effects Line-break remove related to "lint-staged" Related to ngrx#1487
|
Preview docs changes for 354b0b8 at https://previews.ngrx.io/pr1494-354b0b8/ |
timdeschryver
requested changes
Dec 29, 2018
| }, | ||
| "path": { | ||
| "type": "string", | ||
| "format": "path", | ||
| "description": "The path to create the effect.", | ||
| "visible": false | ||
| }, | ||
| "project": { |
There was a problem hiding this comment.
Nit: Could you move this to above module, because it's located there in every other file.
Reorder the schema.json and schema.ts file having the project property above the module property
|
Preview docs changes for 8b25cdb at https://previews.ngrx.io/pr1494-8b25cdb/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing project keys to schema.json
for store, store-devtools and effects
Line-break remove related to "lint-staged" in "precommit" package.json command
Related to #1487
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?