Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(entity): add selector to select entity by id #1182

Closed
wants to merge 2 commits into from
Closed

feat(entity): add selector to select entity by id #1182

wants to merge 2 commits into from

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Jul 12, 2018

  • add a new selector 'selectById' to EntitySelector (model)
  • implement selector, function to take id string || number
  • add tests

See: #1156

@mgred
feat(entity): add selector to select entity by id
c3faa26 
* add a new selector 'selectById' to EntitySelector (model)
* implement selector, function to take id string || number
* add tests

See: ngrx#1156
@coveralls
Copy link

coveralls commented Jul 12, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 88.177% when pulling 00676ba on mgred:ngrx/1156 into 2cb81d8 on ngrx:master.

@timdeschryver
Copy link
Member

timdeschryver commented Aug 17, 2018 •
edited
Loading

Hi @mgred thanks for the PR, but this was resolved with #1194 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgred @coveralls @timdeschryver