Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Dev Tools support for persist, lock, pause #853

Closed
dummdidumm opened this issue Feb 23, 2018 · 2 comments · Fixed by #955
Closed

RFC: Dev Tools support for persist, lock, pause #853

dummdidumm opened this issue Feb 23, 2018 · 2 comments · Fixed by #955

Comments

@dummdidumm
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

What is the current behavior?

The redux dev tools extension has the following features which are not usable with ngrx at the moment:

  • persist: If enabled, the state of the redux dev tools survive a full reload of the page. The persisted actions are fired against the initial state. This makes developing applications faster. Imagine you don't use HMR and have to fix something from the example application - every reload throws you back to the login page. With the persist feature, this would no longer be the case.
  • lock/unlock: If locked, no new actions will get through to the reducer, the app is basically frozen. In combination with persist / HMR, this is a great developer experience when you want to focus on a specific feature with a specific number/order of actions.
  • pause/unpause: If paused, the redux dev tools will not record the actions fired. The app will continue to work. Useful if you don't want to get spammed with lots of actions. When you unpause, the current state will be committed and recording is resumed.

Locking and pausing is explained in more details here.

Expected behavior:

Features also work with ngrx dev tools.

Other information:

I'm willing to help with PRs.

@MikeRyanDev
Copy link
Member

I'm down with these changes for NgRx 6. I don't know enough about Redux's devtools to help implement these. Would you be able to make these changes @dummdidumm?

@dummdidumm
Copy link
Contributor Author

Sure, I'll look into it. The referenced PR is a first step to lay the groundwork for persist.

dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 3, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 4, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Apr 13, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Jul 30, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Jul 30, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Jul 30, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Jul 30, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Jul 30, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Jul 30, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Aug 8, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Aug 8, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Aug 8, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Aug 8, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Aug 8, 2018
dummdidumm added a commit to dummdidumm/platform that referenced this issue Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants