Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta reducers ignored with forFeature #701

Closed
dasch8 opened this issue Jan 7, 2018 · 0 comments
Closed

Meta reducers ignored with forFeature #701

dasch8 opened this issue Jan 7, 2018 · 0 comments

Comments

@dasch8
Copy link

dasch8 commented Jan 7, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

When a single reducer (not a reducer map) for a feature module is added with forFeature, the supplied meta-reducers are ignored.

Expected behavior:

Meta-reducers should also be added when a single reducer is given instead of a reducer map.

Minimal reproduction of the problem with instructions:

  1. Add a single reducer and meta-reducer(s) for a feature:
StoreModule.forFeature('feature', fromFeature.reducer, {
    metaReducers: [fromFeature.metaReducer]
)

Plunker

Version of affected browser(s),operating system(s), npm, node and ngrx:

all

Other information:

The bug seems to be at

? (state: any, action: any) => reducers(state || initialState, action)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants