-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
action-/stateSanitizer configuration does not make it into the extension. #604
Comments
Note: This also blocks the ability to dispatch an |
Hi @timblakely |
Hi @brandonroberts I just committed the fix and tested it. Action/State sanitizers are getting called now. |
Hey @timblakely! I've also created #795 to address this.
I'm not sure how to test that this problem is resolved, but please feel free to try it out. |
Hi @kgkma I think you are correct. The way you did the fix makes more sense. |
Fixed via #795 |
I'm submitting a...
What is the current behavior?
actionSanitizer
andstateSanitizer
, if specified in the config, are not called.Other information:
#544 added support for
actionSanitizer
andstateSanitizer
, but unfortunately they never make it into the extension.StoreDevtools
usesnotify
to send updates to the extension, which in turn callsdevtoolsExtension.send
withnull, state, this.config, this.instanceId
. The config object does have the state-/actionSanitizers properties, but thesendMessage
function in the extension does not reference them nor passes the config into the extension, and are subsequently ignored.The text was updated successfully, but these errors were encountered: