Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action-/stateSanitizer configuration does not make it into the extension. #604

Closed
timblakely opened this issue Nov 26, 2017 · 6 comments
Closed

Comments

@timblakely
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

actionSanitizer and stateSanitizer, if specified in the config, are not called.

Other information:

#544 added support for actionSanitizer and stateSanitizer, but unfortunately they never make it into the extension. StoreDevtools uses notify to send updates to the extension, which in turn calls devtoolsExtension.send with null, state, this.config, this.instanceId. The config object does have the state-/actionSanitizers properties, but the sendMessage function in the extension does not reference them nor passes the config into the extension, and are subsequently ignored.

@timblakely
Copy link
Contributor Author

Note: This also blocks the ability to dispatch an Action whose payload is/contains an ActivatedRoute while using @ngrx/store-devtools (or any other payload with circular references).

@rupeshtiwari
Copy link
Contributor

Hi @timblakely
I will start working on this issue.

rupeshtiwari added a commit to rupeshtiwari/platform that referenced this issue Feb 4, 2018
fix: making sure action/state sanitizer getting called by devtool extension
@rupeshtiwari
Copy link
Contributor

Hi @brandonroberts I just committed the fix and tested it. Action/State sanitizers are getting called now.

@kgkma
Copy link
Contributor

kgkma commented Feb 7, 2018

Hey @timblakely! I've also created #795 to address this.

Note: This also blocks the ability to dispatch an Action whose payload is/contains an ActivatedRoute while using @ngrx/store-devtools (or any other payload with circular references).

I'm not sure how to test that this problem is resolved, but please feel free to try it out.

@rupeshtiwari
Copy link
Contributor

Hi @kgkma I think you are correct. The way you did the fix makes more sense.

@brandonroberts
Copy link
Member

Fixed via #795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants