Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/component-store: Add migration schematic for tapResponse operator #4261

Closed
1 of 2 tasks
markostanimirovic opened this issue Feb 22, 2024 · 1 comment · Fixed by #4321
Closed
1 of 2 tasks

@ngrx/component-store: Add migration schematic for tapResponse operator #4261

markostanimirovic opened this issue Feb 22, 2024 · 1 comment · Fixed by #4321
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Component Store

Comments

@markostanimirovic
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

component-store

Information

Before:

import { tapResponse } from '@ngrx/component-store';

After:

import { tapResponse } from '@ngrx/operators';

The schematic should also add @ngrx/operators package to package.json => dependencies if it's not already installed.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@rainerhahnekamp
Copy link
Contributor

As in #4262: I'd like to work on that one.

@markostanimirovic markostanimirovic added the community watch Someone from the community is working this issue/PR label Feb 27, 2024
rainerhahnekamp added a commit to rainerhahnekamp/ngrx that referenced this issue May 8, 2024
Migrates any `import` of `tapResponse` from `@ngrx/component-store`
to `@ngrx/operators`.

Fixes ngrx#4261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Project: Component Store
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants