Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on the Lifecycle page #4010

Closed
1 of 2 tasks
markostanimirovic opened this issue Aug 18, 2023 · 2 comments · Fixed by #4015
Closed
1 of 2 tasks

Fix typo on the Lifecycle page #4010

markostanimirovic opened this issue Aug 18, 2023 · 2 comments · Fixed by #4015
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor

Comments

@markostanimirovic
Copy link
Member

markostanimirovic commented Aug 18, 2023 •
edited
Loading

Information

Type should be fixed here: ComoponentStore => ComponentStore

Documentation page

https://ngrx.io/guide/component-store/lifecycle

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@markostanimirovic markostanimirovic added Comp: Docs Accepting PRs Good First Issue Good issue for first-time contributor labels Aug 18, 2023
@srinathsree66
Copy link
Contributor

Hi, Is anyone working on it? If no, I want to try.

@markostanimirovic
Copy link
Member Author

Thanks @srinathsree66! Feel free to create a PR.

@markostanimirovic markostanimirovic added the community watch Someone from the community is working this issue/PR label Aug 20, 2023
@srinathsree66 srinathsree66 mentioned this issue Aug 20, 2023
Merged
3 tasks
markostanimirovic pushed a commit that referenced this issue Aug 21, 2023
@srinathsree66
docs(component-store): fix typo on the lifecycle page (#4015)
54a01c3 
Closes #4010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Comp: Docs Good First Issue Good issue for first-time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(component-store): fix typo on the lifecycle page srinathsree66/ngrx
2 participants
@markostanimirovic @srinathsree66